edgevoid/vue-tui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(runtime): install console patch before first mount so initial [Vue warn] is filtered (#151)

Browse Source 
A [Vue warn] emitted during the initial mount (e.g. the missing-render-
function warn from a root setup() throw) escaped the stderr filter
because mount() installed the console patch only after originalMount.
Ink patches in its constructor before the first React render
(ink.tsx:435-436); move the install before originalMount to match.
The mount-throw catch already restores the console via teardown().

Verified red-first against real Ink v7.0.4 (audit e10): Ink's stderr
stays empty for a render-throwing component; vue-tui's initial-mount
warn reached a real PTY before this fix.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Yunfei He
2026-06-12 02:23:32 +08:00
committed by GitHub
parent 1bd91dbbb9
commit 814c482d6d
5 changed files with 173 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/runtime/src/render.ts
+28 -22
View File
@@ -1120,6 +1120,34 @@ export function createApp(root: Component, rootProps?: RootProps | null): TuiApp
}
mountedAlternateScreen = alternateScreen;
// Patch console.log/warn/error etc. to route through writeToStdout /
// writeToStderr so console output doesn't corrupt the rendered frame.
// Installed BEFORE originalMount (matching Ink, which patches in its
// constructor before the first render — ink.tsx:435-436): a dev-only
// [Vue warn] emitted DURING the initial mount (e.g. the missing-render-
// function warn when the root's setup() throws) must hit the filter too.
// The mount-throw catch below runs teardown(), which restores the console,
// so a synchronous mount failure cannot leak a patched console.
// Disabled in debug mode (matching Ink).
if (options.patchConsole !== false && !debug) {
try {
mountedRestoreConsole = patchConsoleFn((stream, data) => {
if (stream === "stdout") {
appContext.writeToStdout(data);
}
if (stream === "stderr") {
// Filter Vue internal warnings
if (!data.startsWith("[Vue warn]")) {
appContext.writeToStderr(data);
}
}
});
} catch {
// patch-console uses console.Console which may not be available in
// some environments (e.g., vitest workers). Degrade gracefully.
}
}
// No eager mount-time cursor hide here (matching Ink). Ink hides the cursor
// LAZILY: the non-alt-screen hide comes from log-update's isTTY-gated
// cliCursor.hide on the first render that actually writes (log-update.ts:
@@ -1258,28 +1286,6 @@ export function createApp(root: Component, rootProps?: RootProps | null): TuiApp
mountedUnsubscribeExit = onExit(() => teardown(true), { alwaysLast: false });
}
// Patch console.log/warn/error etc. to route through writeToStdout /
// writeToStderr so console output doesn't corrupt the rendered frame.
// Disabled in debug mode (matching Ink).
if (options.patchConsole !== false && !debug) {
try {
mountedRestoreConsole = patchConsoleFn((stream, data) => {
if (stream === "stdout") {
appContext.writeToStdout(data);
}
if (stream === "stderr") {
// Filter Vue internal warnings
if (!data.startsWith("[Vue warn]")) {
appContext.writeToStderr(data);
}
}
});
} catch {
// patch-console uses console.Console which may not be available in
// some environments (e.g., vitest workers). Degrade gracefully.
}
}
return proxy;
};