edgevoid/vue-tui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: correct flex basis column test expectations to match Ink output

Browse Source 
height=6 containers produce 6 lines. Ink's renderToString returns
"A\n\n\nB\n\n" (preserving trailing blank lines). The tests incorrectly
expected "A\n\n\nB" with a comment claiming lastFrame({ trimLines: true })
trims trailing newlines — it does not; it only trims trailing spaces per
line.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Yunfei He
2026-05-25 22:37:10 +08:00
parent 5a1f2eba2d
commit d14c11e2d2
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/runtime-tests/integration/layout/flex.test.tsx
+2 -4
View File
@@ -115,8 +115,7 @@ test('set flex basis with flexDirection="column" container', async () => {
)), )),
{ columns: 100 }, { columns: 100 },
); );
// Ink: "A\n\n\nB\n\n" — trailing newlines trimmed by lastFrame({ trimLines: true }) expect(lastFrame({ trimLines: true })).toBe("A\n\n\nB\n\n");
expect(lastFrame({ trimLines: true })).toBe("A\n\n\nB");
}); });
test('set flex basis in percent with flexDirection="column" container', async () => { test('set flex basis in percent with flexDirection="column" container', async () => {
@@ -131,6 +130,5 @@ test('set flex basis in percent with flexDirection="column" container', async ()
)), )),
{ columns: 100 }, { columns: 100 },
); );
// Ink: "A\n\n\nB\n\n" — trailing newlines trimmed by lastFrame({ trimLines: true }) expect(lastFrame({ trimLines: true })).toBe("A\n\n\nB\n\n");
expect(lastFrame({ trimLines: true })).toBe("A\n\n\nB");
}); });