fix(runtime): set Static yoga node to display:none in dynamic layout
Static content is rendered via paintIsolated (separate channel), but its yoga node was still participating in the dynamic frame layout calculation, adding blank lines equal to the Static content height between the last Static item and the dynamic content below. Setting display:none on the Static yoga node removes it from the dynamic layout. paintIsolated is unaffected — it reparents children into a temporary yoga tree.
This commit is contained in:
@@ -130,3 +130,28 @@ test("Static flush clears the dynamic frame first (non-debug mode)", async () =>
|
|||||||
|
|
||||||
app.unmount();
|
app.unmount();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test("Static items do not add blank lines to the dynamic frame", async () => {
|
||||||
|
const items = ref<string[]>([]);
|
||||||
|
|
||||||
|
const App = defineComponent(() => () => (
|
||||||
|
<Box flexDirection="column">
|
||||||
|
<Static items={items.value}>
|
||||||
|
{{
|
||||||
|
default: ({ item }: { item: string }) => <Text>{item}</Text>,
|
||||||
|
}}
|
||||||
|
</Static>
|
||||||
|
<Text>[live]</Text>
|
||||||
|
</Box>
|
||||||
|
));
|
||||||
|
|
||||||
|
const { lastFrame } = await render(App);
|
||||||
|
expect(lastFrame()).toBe("[live]");
|
||||||
|
|
||||||
|
items.value = ["a", "b", "c"];
|
||||||
|
await nextTick();
|
||||||
|
|
||||||
|
// The dynamic frame should ONLY contain [live], no blank lines from Static
|
||||||
|
const frame = lastFrame()!;
|
||||||
|
expect(frame).toBe("[live]");
|
||||||
|
});
|
||||||
|
|||||||
@@ -43,6 +43,11 @@ function hasYoga(node: TuiNode): node is YogaCarrier {
|
|||||||
|
|
||||||
export function attachYoga(node: YogaCarrier): void {
|
export function attachYoga(node: YogaCarrier): void {
|
||||||
node.yoga = createYogaNode();
|
node.yoga = createYogaNode();
|
||||||
|
// Static nodes are painted via a separate channel (paintIsolated), so they
|
||||||
|
// must not occupy space in the dynamic frame's yoga layout.
|
||||||
|
if (node.type === "static") {
|
||||||
|
(node.yoga as YogaNode).setDisplay(Yoga.DISPLAY_NONE);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
export function detachYoga(node: YogaCarrier): void {
|
export function detachYoga(node: YogaCarrier): void {
|
||||||
|
|||||||
Reference in New Issue
Block a user