fix(ci): make lint depend on build in the ci graph
Third CI run failed: `vp lint --deny-warnings` reported 4 no-implied-eval warnings on PTY fixtures (setTimeout(exit, ...)). The type-aware rule needs @vue-tui/runtime's built types to prove the callback is a function; on a fresh checkout dist doesn't exist yet, so it misfires. Locally it was hidden because dist was always present. Add dependsOn: ["ci:build"] to ci:lint. build is already on the critical path (build -> test:pty), so overall wall-clock is unchanged. Verified by removing all dist and running vp run ci: exit 0, 0 lint warnings, all tests pass.
This commit is contained in:
+5
-1
@@ -29,7 +29,11 @@ export default defineConfig({
|
||||
tasks: {
|
||||
"ci:build": { command: "vp run build" },
|
||||
"ci:fmt": { command: "vp run check:fmt" },
|
||||
"ci:lint": { command: "vp run check:lint" },
|
||||
// lint depends on build: type-aware rules (e.g. no-implied-eval) on the
|
||||
// PTY fixtures need @vue-tui/runtime's built types resolved, or they
|
||||
// misfire on a fresh checkout. build is already on the critical path, so
|
||||
// this doesn't change overall wall-clock.
|
||||
"ci:lint": { command: "vp run check:lint", dependsOn: ["ci:build"] },
|
||||
"ci:type": { command: "vp run check:type", dependsOn: ["ci:build"] },
|
||||
"ci:test:integration": {
|
||||
command: "vp run -r test:integration",
|
||||
|
||||
Reference in New Issue
Block a user